Skip to content

cut: rm _GLIBCXX_ASSERTIONS define#10108

Merged
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:bzl-no-glibccxx-assertions
Apr 11, 2026
Merged

cut: rm _GLIBCXX_ASSERTIONS define#10108
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:bzl-no-glibccxx-assertions

Conversation

@openroad-ci

Copy link
Copy Markdown
Member

Summary

This can cause problems depending the libcstd++ linked against.

Type of Change

  • Bug fix

Verification

  • I have verified that the local build succeeds (./etc/Build.sh).
  • I have run the relevant tests and they pass.
  • My code follows the repository's formatting guidelines.
  • I have signed my commits (DCO).

This can cause problems depending the libcstd++ linked against.

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
@github-actions

Copy link
Copy Markdown
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the _GLIBCXX_ASSERTIONS preprocessor definition from the src/cut build configuration, which disables runtime assertions for the GNU C++ library. I have no feedback to provide as there were no review comments.

@maliberty maliberty enabled auto-merge April 11, 2026 06:17
@maliberty maliberty merged commit 115f1e5 into The-OpenROAD-Project:master Apr 11, 2026
17 checks passed
@maliberty maliberty deleted the bzl-no-glibccxx-assertions branch April 11, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants